On 03/06/2015 04:23 PM, Janne Blomqvist wrote:
The patch as is causes gfortran.dg/open_errors.f90 to fail, due to changed error messages. I'm a bit unsure of to fix this, as now strerror* is used to generate part of the message, and thus the message can be different on different targets, and even dependent on the locale settings. Just checking for the fixed part of the error message doesn't seem that useful in this case; should the entire testcase just be removed?
Generally the patch is OK as FX has stated. I am concerned about the strerror messages being less helpful to users than the ones we have. However, you can either keep the same error messages for those few or update the test case to use the error codes (iostat) if that makes more sense.
Jerry
