On 02/23/2015 10:37 AM, Jason Merrill wrote:
On 02/19/2015 12:31 PM, Aldy Hernandez wrote:
As explained in the PR, I would ideally like to get rid of the kludge
where we set the location of location-less FINALLY statements to be that
of the TRY statement, but that may be by design, and/or beyond the scope
of this fix.

This reminds me of the semi-recent change to disassociate variable
cleanups with the location of the declaration.  I think Jakub added a
pass specifically for this purpose?  I think making the change you
suggest would make sense, but probably as a separate patch.

Absolutely, and that's why I closed the PR with the fix to the TRY_FINALLY gimple code. That at least fixes the regression.

thanks.
Aldy

Reply via email to