> On Feb 19, 2015, at 4:31 PM, H.J. Lu <hjl.to...@gmail.com> wrote:
>
> On Wed, Feb 18, 2015 at 7:05 AM, Maxim Kuvyrkov
> <maxim.kuvyr...@linaro.org> wrote:
>> Hi,
>>
>> This testsuite patch fixes race on additional_source testsuite variable.
>> When a test has both dg-additional-sources and "dg-do run { target FOO }"
>> directives, it may occur that the FOO test will attempt to use
>> additional_sources, which will result in failure to compile FOO test. It
>> often happens that FOO test was done for one of the previous testcases
>> (which didn't use dg-additional-sources), so the failure case is not stable.
>>
>> This behavior can be more-or-less reliably triggered with
>>
>> make check-gcc make RUNTESTFLAGS="i386.exp=gcc.target/i386/pr64291-1.c"
>>
>> The attached patch fixes the problem. OK for trunk and 4.9 branch?
>>
>
> It caused:
>
> ERROR: 17_intro/shared_with_static_deps.cc: can't read
> "additional_sources": no such variable for "
> dg-require-effective-target 4 fpic "
Yes, this is PR65116. I've screwed up testing of the patch. Reverted on 4.9
branch for now, and will post a fix for trunk shortly.
--
Maxim Kuvyrkov
www.linaro.org
