On Wed, Feb 18, 2015 at 11:44 AM, Mike Frysinger <[email protected]> wrote: > On 18 Feb 2015 08:58, H.J. Lu wrote: >> On Wed, Feb 18, 2015 at 8:54 AM, Mike Frysinger wrote: >> > On 18 Feb 2015 04:56, H.J. Lu wrote: >> >> On Wed, Feb 18, 2015 at 4:08 AM, Joel Brobecker wrote: >> >> > On Wed, Jan 07, 2015 at 06:45:48PM +0400, Joel Brobecker wrote: >> >> >> This patch enhances config/zlib.m4 to introduce an extra option >> >> >> --with-libz-prefix which allows us to provide the location of >> >> >> the zlib library we want to use during the build. >> >> >> >> >> >> config/ChangeLog: >> >> >> >> >> >> * zlib.m4 (AM_ZLIB): Add --with-libz-prefix option support. >> >> >> >> >> >> I didn't see any file in the GCC project that uses this macro, >> >> >> so for the GCC repository, the change to zlib.m4 is it. But >> >> >> I am also attaching to this email a copy of the patch that >> >> >> will be applied to the binutils-gdb.git repository, with all >> >> >> configury using this macro being re-generated - mostly for info, >> >> >> also as a heads-up to both binutils and GDB. >> >> >> >> >> >> This was tested by regenerating all autoconf/automake files in >> >> >> the binutils-gdb project, and rebuilding GDB, using the following >> >> >> combinations: >> >> >> >> >> >> --with-zlib (system zlib used) >> >> >> --with-libz-prefix=/zlib/prefix (specific zlib linked in) >> >> >> --with-zlib --with-libz-prefix=/zlib/prefix (specific zlib linked in) >> >> >> >> >> >> --without-zlib (zlib support turned off) >> >> >> --without-zlib --with-zlib-prefix (zlib support turned off) >> >> >> >> >> >> --with-zlib (no system zlib available, configure fails with expected >> >> >> error) >> >> >> --with-zlib --with-libz-prefix=/invalid/zlib/prefix >> >> >> (no system zlib, configure fails with same error) >> >> >> >> >> >> OK to commit? >> >> >> >> Why do you want to turn off zlib? On Linux/x86, zlib is required >> >> for assembler. At least, you should issue an error when --without-libz >> >> is used in binutils for Linux/x86 target. >> > >> > err, when did that happen ? why would zlib be possibly required for an >> > assembler ? >> >> commit 89e7505fcde4bd83948f559f429a0e1eb4262f05 >> Author: H.J. Lu <[email protected]> >> Date: Sun Dec 14 06:41:03 2014 -0800 >> >> Compress debug sections for Linux/x86 by default >> >> * config/tc-i386.c (flag_compress_debug): Default to compress >> debug sections for Linux. > > i don't see how that justifies making it a hard requirement > -mike
Can you elaborate? -- H.J.
