On 02/09/2015 11:49 PM, Pedro Alves wrote: > On 02/09/2015 11:35 PM, Andrew Pinski wrote: >> On Mon, Feb 9, 2015 at 3:20 PM, Pedro Alves <pal...@redhat.com> wrote: >>> Just like libiberty.h. So that C++ programs, such as GDB when built >>> as a C++ program, can use it. >> >> Why is not needed for GCC building with C++ compiler? > > Because it doesn't include it. > > The header of the file claims it is part of GDB, though MAINTAINERS > nowadays says that everything under include/ is owned by GCC.
Here's an update that moves the extern "C" below the #include. OK to push to the GCC repo? From: Pedro Alves <pal...@redhat.com> Subject: [PATCH] floatformat.h: Wrap in extern "C". Just like libiberty.h. So that C++ programs, such as GDB when built as a C++ program, can use it. include/ChangeLog: 2015-02-12 Pedro Alves <pal...@redhat.com> * floatformat.h [__cplusplus]: Wrap in extern "C". --- include/floatformat.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/floatformat.h b/include/floatformat.h index 6b559864..af4d09c 100644 --- a/include/floatformat.h +++ b/include/floatformat.h @@ -22,6 +22,10 @@ Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. #include "ansidecl.h" +#ifdef __cplusplus +extern "C" { +#endif + /* A floatformat consists of a sign bit, an exponent and a mantissa. Once the bytes are concatenated according to the byteorder flag, then each of those fields is contiguous. We number the bits with 0 being the most significant @@ -148,4 +152,8 @@ floatformat_from_double (const struct floatformat *, const double *, void *); extern int floatformat_is_valid (const struct floatformat *fmt, const void *from); +#ifdef __cplusplus +} +#endif + #endif /* defined (FLOATFORMAT_H) */ -- 1.9.3