On Wed, Jan 28, 2015 at 11:44 AM, Cary Coutant <ccout...@google.com> wrote: >>>>This patch makes claim_file_handler to call release_input_file after it >>>>finishes processing input file. OK for trunk? >>> >>> OK. How did you test this? >> >> I did normal bootstrap and "make check" on Linux/x86-64. >> I also run ld.bfd and ld.gold by hand to verify that release_input_file >> is called. > > But release_input_file is only supposed to be used after calling > get_input_file from the all_symbols_read handler. It's not needed in > the claim_file handler. If gold isn't freeing the file descriptor > properly in that case, it's a bug entirely within gold (I think). I'm > looking at it.
release_input_file should be allowed in the claim_file handler since GCC plugin doesn't use get_input_file at all. -- H.J.
