> From: Andrew Pinski [mailto:pins...@gmail.com] > Sent: Friday, January 16, 2015 6:03 PM > >
> > +/* Defined in config/aarch64/fma_steering.c. */ > > + > > +void > > +aarch64_register_fma_steering (void); > > > This is really bad form. Can you add a header file for this > declaration and maybe future declarations too? > Maybe called aarch64-internal.h and include this header file both in > aarch64.c and fma_steering.c. Hi Andrew, cortex-a57-fma-steering.c is really meant to be autosufficient with aarch64_register_fma_steering being the only interface which is why I thought it was not worth the trouble. Now I'm not saying I'm against it as it do make this interface more explicit. I'm currently about to take a plane but I'll change it as soon as I arrive at work. Best regards, Thomas
