On Mon, Jun 27, 2011 at 10:18 AM, Diego Novillo <dnovi...@google.com> wrote: > On Mon, Jun 27, 2011 at 13:13, Gabriel Charette <gch...@google.com> wrote: >> On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo <dnovi...@google.com> wrote: >>> On Mon, Jun 27, 2011 at 13:01, Gabriel Charette <gch...@google.com> wrote: >>>> Couldn't we have headers look for their corresponding .pph file by >>>> default when -fpph-map is on? (especially since pph.map is only >>>> temporary for the implementation phase) >>> >>> The problem is with headers that include other headers. We want to >>> limit the generation of images to specific headers. Given that we are >>> in this initial implementation phase, the simplest approach is to >>> remember to update pph.map. >> >> Well in what I'm proposing we only use the pph file if it was actually >> generated before (we don't generate it if it's not there). Are there >> any situations where we have a corresponding pph file, but don't >> actually want to use it when the fpph-map flag is on? Seems unlikely >> as we put all the pph files in the pph map for now anyways... > > Headers include other headers. We are not generating PPH for all headers. > > The mapping file also allows us to control what happens when > generating a PPH file that emits #include directives itself. Some of > those we want to have referenced as PPH, but not all. > > It's really easier for us to remember to update the mapping file > rather than adding some automatic detection that would have to be > removed later.
Ok I agree, temporary flags and map files are better then temporary code for the implementation phase. LGTM, Gab > > Diego. >
