On Thu, 16 Jun 2011, Janis Johnson wrote:

> Currently the dg-final check "object-size" results in ERROR if the
> assemble failed and the object file does not exist.  This patch fails
> the test instead.  OK for trunk?

The set of testcase names - the things after "PASS: " or "FAIL: " or other 
statuses - should not depend on the results if comparison is to work well, 
so

+       fail "$testcase $output_file does not exist"

is a bad idea unless there is a corresponding

        pass "$testcase $output_file does not exist"

(obvious nonsense) as the alternative.  Instead you should:

* Make sure the compilation of the test produced its own PASS or FAIL 
line.

* If that failed, report the subsequent test as UNRESOLVED.

        unresolved "$testcase object-size $what $cmp $with"

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to