Kaz Kojima <kkoj...@rr.iij4u.or.jp> writes:
> gcc.dg/torture/tls/run-gd.c fails on SH because SH assumes
> -fpic for global and local dynamic tls models. Although a line
>
> /* { dg-options "-fpic" { target sh*-*-* } } */
>
> added to run-gd.c and run-ld.c tests looks enough for SH,
> I guess that target fpic instead of target sh*-*-* is more
> reasonable because GD and LD tls models are usually for shared
> objects.
I don't think so: on all my targets (Solaris/SPARC and /x86, IRIX and
Tru64 UNIX), the test works without -fpic, so this seems to be quite
target specific.
> I see similar failures on S390 testresults and it seems that
> also S390 requires -fpic for GD and LD.
> Give me your thoughts?
Given that this seems to be target-specific, unless we can identify a
common feature of these targets, I'd rather see us xfail or skip the
tests on a per-target basis.
In addition, I've got a patch in the works that cycles the
gcc.dg/torture/tls tests through -fpic/-fPIC and -fpie/-fPIE if
available. This way, the testcases will be exercised on sh*-*-*, too.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
