On Mon, May 30, 2011 at 01:16:13PM +0200, Eric Botcazou wrote:
> > This should be cfa_base_rtx instead of arg_pointer_rtx, or the condition
> > should test that cfa_base_rtx == arg_pointer_rtx. We don't have a dynamic
> > stack realignment target which defines FRAME_POINTER_CFA_OFFSET right now,
> > but what if one day such target is added or just dynamic realignment
> > support is added.
>
> OK, I wondered about that in the original patch. Will adjust and re-test.
I think re-test is just waste of cycles, as you know cfa_base_rtx is
arg_pointer_rtx on both x86_64 and i686 (it is frame_pointer_rtx only on pa,
vax and rx). IMHO just testing if var-tracking still compiles without
warnings ought to be enough.
Jakub
