On Thu, May 5, 2011 at 12:54 AM, Corinna Vinschen <vinsc...@redhat.com> wrote: > On May 5 00:40, Andrew Pinski wrote: >> On Thu, May 5, 2011 at 12:30 AM, Corinna Vinschen <vinsc...@redhat.com> >> wrote: >> > Thanks, >> > Corinna >> > >> > >> > * strsignal.c (psignal): Change second parameter to const char *. >> > Fix comment accordingly. >> >> >> I don't think this is needed. What goes wrong without it? > > It's not about need, it's about correctness. It collides with the new, > POSIXly correct declaration of psignal in newlib/libc/include/signal.h.
But this could should not show up if psignal is declared. So it should not matter if it collides with that declaration. Thanks, Andrew Pinski