On Tue, Apr 05, 2011 at 02:06:14PM -0700, Nathan Froyd wrote:
> On Tue, Apr 05, 2011 at 04:19:39PM +0200, Jakub Jelinek wrote:
> > + for (i = 0; i < VEC_length (deferred_locations,
> > deferred_locations_list); i++)
> > + {
> > + add_location_or_const_value_attribute (
> > + VEC_index (deferred_locations, deferred_locations_list, i)->die,
> > + VEC_index (deferred_locations, deferred_locations_list, i)->variable,
> > + false,
> > + DW_AT_location);
> > + }
>
> Tiny, non-binding suggestion: use FOR_EACH_VEC_ELT here?
Feel free to do that afterwards, while diff decided to include that
part of code in the patch, it wasn't actually changing at all, what changed
was that the code afterwards was moved into a separate function
and the length of the code being moved probably was bigger than
length from dwarf2out_finish start to that point.
Jakub
