[gcc r14-11547] [RISC-V][PR target/116308] Fix generation of initial RTL for atomics

[Kito Cheng via Gcc-cvs]

https://gcc.gnu.org/g:f3ac41f84249d10a1685c73d67e5d071902fcc4c

commit r14-11547-gf3ac41f84249d10a1685c73d67e5d071902fcc4c
Author: Jeff Law <j...@ventanamicro.com>
Date:   Sat Jan 18 13:44:33 2025 -0700

    [RISC-V][PR target/116308] Fix generation of initial RTL for atomics
    
    While this wasn't originally marked as a regression, it almost certainly is
    given that older versions of GCC would have used libatomic and would not 
have
    ICE'd on this code.
    
    Basically this is another case where we directly used simplify_gen_subreg 
when
    we should have used gen_lowpart.
    
    When I fixed a similar bug a while back I noted the code in question as 
needing
    another looksie.  I think at that time my brain saw the mixed modes (SI & 
QI)
    and locked up.  But the QI stuff is just the shift count, not some deeper
    issue.  So fixing is trivial.
    
    We just replace the simplify_gen_subreg with a gen_lowpart and get on with 
our
    lives.
    
    Tested on rv64 and rv32 in my tester.  Waiting on pre-commit testing for 
final
    verdict.
    
            PR target/116308
    gcc/
            * config/riscv/riscv.cc (riscv_lshift_subword): Use gen_lowpart
            rather than simplify_gen_subreg.
    
    gcc/testsuite/
    
            * gcc.target/riscv/pr116308.c: New test.

Diff:
---
 gcc/config/riscv/riscv.cc                 | 4 +---
 gcc/testsuite/gcc.target/riscv/pr116308.c | 9 +++++++++
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 2841787d93e7..a6a3b2745c53 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -10428,9 +10428,7 @@ riscv_lshift_subword (machine_mode mode, rtx value, rtx 
shift,
                      rtx *shifted_value)
 {
   rtx value_reg = gen_reg_rtx (SImode);
-  emit_move_insn (value_reg, simplify_gen_subreg (SImode, value,
-                                                 mode, 0));
-
+  emit_move_insn (value_reg, gen_lowpart (SImode, value));
   emit_move_insn (*shifted_value, gen_rtx_ASHIFT (SImode, value_reg,
                                                  gen_lowpart (QImode, shift)));
 }
diff --git a/gcc/testsuite/gcc.target/riscv/pr116308.c 
b/gcc/testsuite/gcc.target/riscv/pr116308.c
new file mode 100644
index 000000000000..241df14bd922
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/pr116308.c
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+/* { dg-options "-Ofast -march=rv64gc -mabi=lp64d" { target rv64 } } */
+/* { dg-options "-Ofast -march=rv32gc -mabi=ilp32" { target rv32 } } */
+
+_Float16 test__Float16_post_inc()
+{
+    _Atomic _Float16 n;
+    return n++;
+}