https://gcc.gnu.org/g:87e4dcd782013a10de2a1cac8ff0364e5ff06bda

commit r15-8516-g87e4dcd782013a10de2a1cac8ff0364e5ff06bda
Author: Philip Herron <[email protected]>
Date:   Tue Nov 5 17:35:37 2024 +0000

    gccrs: fix ICE for placeholder which is not setup
    
    We can have a case where the placeholder is not configred and the
    can_resolve check is not detecting this case which can lead to ICE.
    
    gcc/rust/ChangeLog:
    
            * typecheck/rust-tyty.cc (PlaceholderType::can_resolve): check for 
empty mappings
    
    Signed-off-by: Philip Herron <[email protected]>

Diff:
---
 gcc/rust/typecheck/rust-tyty.cc | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gcc/rust/typecheck/rust-tyty.cc b/gcc/rust/typecheck/rust-tyty.cc
index 1812c618dcb4..068e39021183 100644
--- a/gcc/rust/typecheck/rust-tyty.cc
+++ b/gcc/rust/typecheck/rust-tyty.cc
@@ -3543,7 +3543,17 @@ bool
 PlaceholderType::can_resolve () const
 {
   auto context = Resolver::TypeCheckContext::get ();
-  return context->lookup_associated_type_mapping (get_ty_ref (), nullptr);
+
+  BaseType *lookup = nullptr;
+  HirId mapping;
+
+  if (!context->lookup_associated_type_mapping (get_ty_ref (), &mapping))
+    return false;
+
+  if (!context->lookup_type (mapping, &lookup))
+    return false;
+
+  return lookup != nullptr;
 }
 
 BaseType *

Reply via email to