https://gcc.gnu.org/g:a00a0e34b8a7312bcf357bd0238d6d9711ca96b2
commit r15-4817-ga00a0e34b8a7312bcf357bd0238d6d9711ca96b2
Author: Richard Sandiford <richard.sandif...@arm.com>
Date: Thu Oct 31 19:52:07 2024 +0000
aarch64: Require SVE2 and/or SME2 for SVE FAMINMAX intrinsics
After the previous patch, we can now accurately model the ISA
requirements for the SVE FAMINMAX intrinsics. They can be used
in non-streaming mode if TARGET_SVE2 and in streaming mode if
TARGET_SME2 (with both cases also requiring TARGET_FAMINMAX).
They can be used in streaming-compatible mode if TARGET_SVE2
&& TARGET_SME2.
Also, Kyrill pointed out in the original review of the FAMINMAX
support that it would be more consistent to define the rtl patterns
in aarch64-sve2.md rather than aarch64-sve.md, so the pushed patch
did that. This patch moves the definitions of the intrinsics to
the sve2 files too, for consistency.
gcc/
* config/aarch64/aarch64-sve-builtins-base.cc (svmax, svamin): Move
definitions to...
* config/aarch64/aarch64-sve-builtins-sve2.cc: ...here.
* config/aarch64/aarch64-sve-builtins-base.def (svmax, svamin): Move
definitions to...
* config/aarch64/aarch64-sve-builtins-sve2.def: ...here. Require
SME2 in streaming mode.
gcc/testsuite/
* gcc.target/aarch64/sve/acle/general/amin_1.c: New test.
* gcc.target/aarch64/sve2/acle/asm/amax_f16.c: Enabled sve2 and
(for streaming mode) sme2.
* gcc.target/aarch64/sve2/acle/asm/amax_f32.c: Likewise.
* gcc.target/aarch64/sve2/acle/asm/amax_f64.c: Likewise.
* gcc.target/aarch64/sve2/acle/asm/amin_f16.c: Likewise.
* gcc.target/aarch64/sve2/acle/asm/amin_f32.c: Likewise.
* gcc.target/aarch64/sve2/acle/asm/amin_f64.c: Likewise.
Diff:
---
gcc/config/aarch64/aarch64-sve-builtins-base.cc | 4 ----
gcc/config/aarch64/aarch64-sve-builtins-base.def | 5 -----
gcc/config/aarch64/aarch64-sve-builtins-sve2.cc | 4 ++++
gcc/config/aarch64/aarch64-sve-builtins-sve2.def | 7 +++++++
gcc/testsuite/gcc.target/aarch64/sve/acle/general/amin_1.c | 9 +++++++++
gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f16.c | 5 ++++-
gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f32.c | 5 ++++-
gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f64.c | 5 ++++-
gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f16.c | 5 ++++-
gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f32.c | 5 ++++-
gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f64.c | 5 ++++-
11 files changed, 44 insertions(+), 15 deletions(-)
diff --git a/gcc/config/aarch64/aarch64-sve-builtins-base.cc
b/gcc/config/aarch64/aarch64-sve-builtins-base.cc
index fe16d93adcd1..1c9f515a52cb 100644
--- a/gcc/config/aarch64/aarch64-sve-builtins-base.cc
+++ b/gcc/config/aarch64/aarch64-sve-builtins-base.cc
@@ -3184,10 +3184,6 @@ FUNCTION (svadrb, svadr_bhwd_impl, (0))
FUNCTION (svadrd, svadr_bhwd_impl, (3))
FUNCTION (svadrh, svadr_bhwd_impl, (1))
FUNCTION (svadrw, svadr_bhwd_impl, (2))
-FUNCTION (svamax, cond_or_uncond_unspec_function,
- (UNSPEC_COND_FAMAX, UNSPEC_FAMAX))
-FUNCTION (svamin, cond_or_uncond_unspec_function,
- (UNSPEC_COND_FAMIN, UNSPEC_FAMIN))
FUNCTION (svand, rtx_code_function, (AND, AND))
FUNCTION (svandv, reduction, (UNSPEC_ANDV))
FUNCTION (svasr, rtx_code_function, (ASHIFTRT, ASHIFTRT))
diff --git a/gcc/config/aarch64/aarch64-sve-builtins-base.def
b/gcc/config/aarch64/aarch64-sve-builtins-base.def
index edfe2574507e..da2a0e41aa5d 100644
--- a/gcc/config/aarch64/aarch64-sve-builtins-base.def
+++ b/gcc/config/aarch64/aarch64-sve-builtins-base.def
@@ -368,8 +368,3 @@ DEF_SVE_FUNCTION (svuzp2q, binary, all_data, none)
DEF_SVE_FUNCTION (svzip1q, binary, all_data, none)
DEF_SVE_FUNCTION (svzip2q, binary, all_data, none)
#undef REQUIRED_EXTENSIONS
-
-#define REQUIRED_EXTENSIONS ssve (AARCH64_FL_FAMINMAX)
-DEF_SVE_FUNCTION (svamax, binary_opt_single_n, all_float, mxz)
-DEF_SVE_FUNCTION (svamin, binary_opt_single_n, all_float, mxz)
-#undef REQUIRED_EXTENSIONS
diff --git a/gcc/config/aarch64/aarch64-sve-builtins-sve2.cc
b/gcc/config/aarch64/aarch64-sve-builtins-sve2.cc
index d29c2209fdfe..64f86035c30e 100644
--- a/gcc/config/aarch64/aarch64-sve-builtins-sve2.cc
+++ b/gcc/config/aarch64/aarch64-sve-builtins-sve2.cc
@@ -591,6 +591,10 @@ FUNCTION (svaesd, fixed_insn_function,
(CODE_FOR_aarch64_sve2_aesd))
FUNCTION (svaese, fixed_insn_function, (CODE_FOR_aarch64_sve2_aese))
FUNCTION (svaesimc, fixed_insn_function, (CODE_FOR_aarch64_sve2_aesimc))
FUNCTION (svaesmc, fixed_insn_function, (CODE_FOR_aarch64_sve2_aesmc))
+FUNCTION (svamax, cond_or_uncond_unspec_function,
+ (UNSPEC_COND_FAMAX, UNSPEC_FAMAX))
+FUNCTION (svamin, cond_or_uncond_unspec_function,
+ (UNSPEC_COND_FAMIN, UNSPEC_FAMIN))
FUNCTION (svbcax, CODE_FOR_MODE0 (aarch64_sve2_bcax),)
FUNCTION (svbdep, unspec_based_function, (UNSPEC_BDEP, UNSPEC_BDEP, -1))
FUNCTION (svbext, unspec_based_function, (UNSPEC_BEXT, UNSPEC_BEXT, -1))
diff --git a/gcc/config/aarch64/aarch64-sve-builtins-sve2.def
b/gcc/config/aarch64/aarch64-sve-builtins-sve2.def
index 345a7621b6f9..e4021559f36d 100644
--- a/gcc/config/aarch64/aarch64-sve-builtins-sve2.def
+++ b/gcc/config/aarch64/aarch64-sve-builtins-sve2.def
@@ -283,3 +283,10 @@ DEF_SVE_FUNCTION (svwhilelt, compare_scalar_count,
while_x_c, none)
DEF_SVE_FUNCTION_GS (svzip, unaryxn, all_data, x24, none)
DEF_SVE_FUNCTION_GS (svzipq, unaryxn, all_data, x24, none)
#undef REQUIRED_EXTENSIONS
+
+#define REQUIRED_EXTENSIONS \
+ sve_and_sme (AARCH64_FL_SVE2 | AARCH64_FL_FAMINMAX, \
+ AARCH64_FL_SME2 | AARCH64_FL_FAMINMAX)
+DEF_SVE_FUNCTION (svamax, binary_opt_single_n, all_float, mxz)
+DEF_SVE_FUNCTION (svamin, binary_opt_single_n, all_float, mxz)
+#undef REQUIRED_EXTENSIONS
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general/amin_1.c
b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/amin_1.c
new file mode 100644
index 000000000000..e2c28cfaf627
--- /dev/null
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/amin_1.c
@@ -0,0 +1,9 @@
+#include <arm_sve.h>
+
+#pragma GCC target "+nosme2+sve2+faminmax+sme"
+
+svfloat32_t
+foo (svfloat32_t x, svfloat32_t y) __arm_streaming
+{
+ return svamin_x (svptrue_b8 (), x, y); /* { dg-error {ACLE function '[^']*'
requires ISA extension 'sme2'} } */
+}
diff --git a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f16.c
b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f16.c
index 3d99e4bd92d7..43c1e4d9c514 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f16.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f16.c
@@ -3,7 +3,10 @@
#include "test_sve_acle.h"
-#pragma GCC target "+sve+faminmax"
+#pragma GCC target "+sve2+faminmax"
+#if STREAMING_COMPATIBLE
+#pragma GCC target "+sme2"
+#endif
/*
** amax_f16_m_tied1:
diff --git a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f32.c
b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f32.c
index 686996625fba..56e6b7333a08 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f32.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f32.c
@@ -3,7 +3,10 @@
#include "test_sve_acle.h"
-#pragma GCC target "+sve+faminmax"
+#pragma GCC target "+sve2+faminmax"
+#if STREAMING_COMPATIBLE
+#pragma GCC target "+sme2"
+#endif
/*
** amax_f32_m_tied1:
diff --git a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f64.c
b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f64.c
index e0f0ac32e54d..458c70517025 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f64.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f64.c
@@ -3,7 +3,10 @@
#include "test_sve_acle.h"
-#pragma GCC target "+sve+faminmax"
+#pragma GCC target "+sve2+faminmax"
+#if STREAMING_COMPATIBLE
+#pragma GCC target "+sme2"
+#endif
/*
** amax_f64_m_tied1:
diff --git a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f16.c
b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f16.c
index f93aed6cba53..4c36c425493e 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f16.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f16.c
@@ -3,7 +3,10 @@
#include "test_sve_acle.h"
-#pragma GCC target "+sve+faminmax"
+#pragma GCC target "+sve2+faminmax"
+#if STREAMING_COMPATIBLE
+#pragma GCC target "+sme2"
+#endif
/*
** amin_f16_m_tied1:
diff --git a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f32.c
b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f32.c
index cc1a343160eb..56943fc06578 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f32.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f32.c
@@ -3,7 +3,10 @@
#include "test_sve_acle.h"
-#pragma GCC target "+sve+faminmax"
+#pragma GCC target "+sve2+faminmax"
+#if STREAMING_COMPATIBLE
+#pragma GCC target "+sme2"
+#endif
/*
** amin_f32_m_tied1:
diff --git a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f64.c
b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f64.c
index b5133f12950a..a93f7d687f55 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f64.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f64.c
@@ -3,7 +3,10 @@
#include "test_sve_acle.h"
-#pragma GCC target "+sve+faminmax"
+#pragma GCC target "+sve2+faminmax"
+#if STREAMING_COMPATIBLE
+#pragma GCC target "+sme2"
+#endif
/*
** amin_f64_m_tied1:
