[gcc r15-4805] diagnostics: fix memory leak of m_option_mgr

[David Malcolm via Gcc-cvs]

https://gcc.gnu.org/g:d1d3c17258a564ade216ec908ac99ab6c78f8e3e

commit r15-4805-gd1d3c17258a564ade216ec908ac99ab6c78f8e3e
Author: David Malcolm <dmalc...@redhat.com>
Date:   Thu Oct 31 12:24:55 2024 -0400

    diagnostics: fix memory leak of m_option_mgr
    
    Fix some noise seen in "make selftest-valgrind".
    
    gcc/ChangeLog:
            * diagnostic.cc (diagnostic_context::finish): Delete and reset
            m_option_mgr.
    
    Signed-off-by: David Malcolm <dmalc...@redhat.com>

Diff:
---
 gcc/diagnostic.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gcc/diagnostic.cc b/gcc/diagnostic.cc
index 477214c15f2b..ecc4bd94eba1 100644
--- a/gcc/diagnostic.cc
+++ b/gcc/diagnostic.cc
@@ -420,6 +420,9 @@ diagnostic_context::finish ()
       m_client_data_hooks = nullptr;
     }
 
+  delete m_option_mgr;
+  m_option_mgr = nullptr;
+
   delete m_urlifier;
   m_urlifier = nullptr;