https://gcc.gnu.org/g:47c16d7c81b3c7012b975f624c6c5c19959c091b

commit 47c16d7c81b3c7012b975f624c6c5c19959c091b
Author: Marc Poulhiès <d...@kataplop.net>
Date:   Mon Aug 5 10:43:05 2024 +0200

    rust: avoid clobbering LIBS
    
    Save LIBS around calls to AC_SEARCH_LIBS to avoid clobbering $LIBS.
    
    ChangeLog:
    
            * configure: Regenerate.
            * configure.ac: Save LIBS around calls to AC_SEARCH_LIBS.
    
    Signed-off-by: Marc Poulhiès <d...@kataplop.net>
    Reviewed-by: Thomas Schwinge <tschwi...@baylibre.com>
    Tested-by: Thomas Schwinge <tschwi...@baylibre.com>

Diff:
---
 configure    | 15 ++++++++-------
 configure.ac | 15 ++++++++-------
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/configure b/configure
index a9ea5258f0f6..d3374ba2229a 100755
--- a/configure
+++ b/configure
@@ -8829,9 +8829,12 @@ fi
 
 # Rust requires -ldl and -lpthread if you are using an old glibc that does not 
include them by
 # default, so we check for them here
-
+# We are doing the test here and not in the gcc/configure to be able to nicely 
disable the
+# build of the Rust frontend in case a dep is missing.
 missing_rust_dynlibs=none
 
+save_LIBS="$LIBS"
+LIBS=
 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for library containing 
dlopen" >&5
 $as_echo_n "checking for library containing dlopen... " >&6; }
 if ${ac_cv_search_dlopen+:} false; then :
@@ -8944,16 +8947,14 @@ if test "$ac_res" != no; then :
 
 fi
 
+CRAB1_LIBS="$LIBS"
+LIBS="$save_LIBS"
 
-if test $ac_cv_search_dlopen = -ldl; then
-    CRAB1_LIBS="$CRAB1_LIBS -ldl"
-elif test $ac_cv_search_dlopen = no; then
+if test "$ac_cv_search_dlopen" = no; then
     missing_rust_dynlibs="libdl"
 fi
 
-if test $ac_cv_search_pthread_create = -lpthread; then
-    CRAB1_LIBS="$CRAB1_LIBS -lpthread"
-elif test $ac_cv_search_pthread_crate = no; then
+if test "$ac_cv_search_pthread_create" = no; then
     missing_rust_dynlibs="$missing_rust_dynlibs, libpthread"
 fi
 
diff --git a/configure.ac b/configure.ac
index adb738ac3464..52db66cc48c5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2038,21 +2038,22 @@ AC_SUBST(PICFLAG)
 
 # Rust requires -ldl and -lpthread if you are using an old glibc that does not 
include them by
 # default, so we check for them here
-
+# We are doing the test here and not in the gcc/configure to be able to nicely 
disable the
+# build of the Rust frontend in case a dep is missing.
 missing_rust_dynlibs=none
 
+save_LIBS="$LIBS"
+LIBS=
 AC_SEARCH_LIBS([dlopen], [dl])
 AC_SEARCH_LIBS([pthread_create], [pthread])
+CRAB1_LIBS="$LIBS"
+LIBS="$save_LIBS"
 
-if test $ac_cv_search_dlopen = -ldl; then
-    CRAB1_LIBS="$CRAB1_LIBS -ldl"
-elif test $ac_cv_search_dlopen = no; then
+if test "$ac_cv_search_dlopen" = no; then
     missing_rust_dynlibs="libdl"
 fi
 
-if test $ac_cv_search_pthread_create = -lpthread; then
-    CRAB1_LIBS="$CRAB1_LIBS -lpthread"
-elif test $ac_cv_search_pthread_crate = no; then
+if test "$ac_cv_search_pthread_create" = no; then
     missing_rust_dynlibs="$missing_rust_dynlibs, libpthread"
 fi

Reply via email to