https://gcc.gnu.org/g:79209273663672ff05663554741fd2558b4aac99
commit r15-2808-g79209273663672ff05663554741fd2558b4aac99
Author: Nathaniel Shead <nathanielosh...@gmail.com>
Date: Tue Aug 6 15:41:38 2024 +1000
c++/modules: Handle instantiating already tsubsted template friend classes
[PR115801]
With modules it may be the case that a template friend class provided
with a qualified name is not found by name lookup at instantiation time,
due to the class not being exported from its module. This causes issues
in tsubst_friend_class which did not handle this case.
This is caused by the named friend class not actually requiring
tsubsting. This was already worked around for the "found by name
lookup" case (g++.dg/template/friend5.C), but it looks like there's no
need to do name lookup at all for this particular case to work.
We do need to be careful to continue to do name lookup to handle
templates from an outer current instantiation though; this patch adds a
new testcase for this as well. This should not impact modules (because
exportingness will only affect namespace lookup).
PR c++/115801
gcc/cp/ChangeLog:
* pt.cc (tsubst_friend_class): Return the type immediately when
no tsubsting or name lookup is required.
gcc/testsuite/ChangeLog:
* g++.dg/modules/tpl-friend-16_a.C: New test.
* g++.dg/modules/tpl-friend-16_b.C: New test.
* g++.dg/template/friend82.C: New test.
Signed-off-by: Nathaniel Shead <nathanielosh...@gmail.com>
Reviewed-by: Patrick Palka <ppa...@redhat.com>
Reviewed-by: Jason Merrill <ja...@redhat.com>
Diff:
---
gcc/cp/pt.cc | 8 ++++++
gcc/testsuite/g++.dg/modules/tpl-friend-16_a.C | 40 ++++++++++++++++++++++++++
gcc/testsuite/g++.dg/modules/tpl-friend-16_b.C | 17 +++++++++++
gcc/testsuite/g++.dg/template/friend82.C | 23 +++++++++++++++
4 files changed, 88 insertions(+)
diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc
index 3e55d5c0fea5..1dde7d167fd6 100644
--- a/gcc/cp/pt.cc
+++ b/gcc/cp/pt.cc
@@ -11732,6 +11732,14 @@ tsubst_friend_class (tree friend_tmpl, tree args)
return TREE_TYPE (tmpl);
}
+ if (TMPL_PARMS_DEPTH (DECL_TEMPLATE_PARMS (friend_tmpl)) == 1)
+ /* The template has already been fully substituted, e.g. for
+
+ template <typename> friend class ::C;
+
+ so we can just return it directly. */
+ return TREE_TYPE (friend_tmpl);
+
tree context = CP_DECL_CONTEXT (friend_tmpl);
if (TREE_CODE (context) == NAMESPACE_DECL)
push_nested_namespace (context);
diff --git a/gcc/testsuite/g++.dg/modules/tpl-friend-16_a.C
b/gcc/testsuite/g++.dg/modules/tpl-friend-16_a.C
new file mode 100644
index 000000000000..e1cdcd98e1e0
--- /dev/null
+++ b/gcc/testsuite/g++.dg/modules/tpl-friend-16_a.C
@@ -0,0 +1,40 @@
+// PR c++/115801
+// { dg-additional-options "-fmodules-ts -Wno-global-module" }
+// { dg-module-cmi test }
+
+module;
+
+template <typename T> struct GMF;
+template <typename T> struct GMF_Hidden {
+ int go() { GMF<T> gmf; return gmf.x; }
+};
+
+template <typename T> struct GMF {
+private:
+ template <typename> friend struct ::GMF_Hidden;
+ int x = 1;
+};
+
+template <typename T> int test_gmf() {
+ GMF_Hidden<T> h; return h.go();
+}
+
+export module test;
+
+export using ::GMF;
+export using ::test_gmf;
+
+export template <typename> struct Attached;
+template <typename T> struct Attached_Hidden {
+ int go() { Attached<T> attached; return attached.x; }
+};
+
+template <typename T> struct Attached {
+private:
+ template <typename> friend struct ::Attached_Hidden;
+ int x = 2;
+};
+
+export template <typename T> int test_attached() {
+ Attached_Hidden<T> h; return h.go();
+}
diff --git a/gcc/testsuite/g++.dg/modules/tpl-friend-16_b.C
b/gcc/testsuite/g++.dg/modules/tpl-friend-16_b.C
new file mode 100644
index 000000000000..d3484ab19b11
--- /dev/null
+++ b/gcc/testsuite/g++.dg/modules/tpl-friend-16_b.C
@@ -0,0 +1,17 @@
+// PR c++/115801
+// { dg-additional-options "-fmodules-ts" }
+
+import test;
+
+int main() {
+ GMF<int> gmf;
+ Attached<int> attached;
+
+ int a = test_gmf<double>();
+ int b = test_attached<double>();
+
+ GMF_Hidden<int> gmf_hidden; // { dg-error "not declared" }
+ Attached_Hidden<int> attached_hidden; // { dg-error "not declared" }
+}
+
+// { dg-prune-output "expected primary-expression" }
diff --git a/gcc/testsuite/g++.dg/template/friend82.C
b/gcc/testsuite/g++.dg/template/friend82.C
new file mode 100644
index 000000000000..28a057dd23e5
--- /dev/null
+++ b/gcc/testsuite/g++.dg/template/friend82.C
@@ -0,0 +1,23 @@
+// { dg-do compile }
+
+template<class T>
+struct A {
+ template<class U> struct B;
+
+ template<class U>
+ struct C {
+ template<class V> friend struct A::B;
+ private:
+ int x;
+ };
+};
+
+template <class T>
+template <class U>
+struct A<T>::B {
+ int foo(A<int*>::C<long> c) { return c.x; } // { dg-error "private" }
+};
+
+template struct A<int*>::C<long>;
+template struct A<int*>::B<long>; // { dg-bogus "" }
+template struct A<double*>::B<long>; // { dg-message "required from here" }
