------- Additional Comments From mark at codesourcery dot com  2004-12-08 03:46 
-------
Subject: Re:  [4.0 regression] mmintrin.h rejected by C++ frontend

reichelt at gcc dot gnu dot org wrote:
> ------- Additional Comments From reichelt at gcc dot gnu dot org  2004-12-07 
> 17:29 -------
> Mark, it looks like your patch only fixed conversion from integer to
> vector but not the other way round. The following patch fixes the problem
> for me. Does this look right?

Yes, but convert_to_vector is badly misnamed (as this usage on your part 
is really convert_from_vector).  Also, I'm disturbed to see that 
convert_to_vector doesn't check that the "type" parameter is either a 
VECTOR_TYPE or an INTEGER_TYPE.

Your patch is OK if it passes testing, but you might also want to 
consider cleaning up the issues with convert_to_vector.  That's not your 
responsibility, though.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18073

Reply via email to