https://gcc.gnu.org/bugzilla/show_bug.cgi?id=127690
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> --- (In reply to Jonathan Wakely from comment #0) > The PB_DS_DATA_TRUE_INDICATOR and PB_DS_DATA_FALSE_INDICATOR macros allow > the same header to be included twice, once to define ov_tree_map and once to > define ov_tree_set. e.g. that's done like this: #define PB_DS_DATA_TRUE_INDICATOR #define PB_DS_V2F(X) (X).first #define PB_DS_V2S(X) (X).second #define PB_DS_EP2VP(X)& ((X)->m_value) #include <ext/pb_ds/detail/list_update_map_/lu_map_.hpp> #include <ext/pb_ds/detail/bin_search_tree_/bin_search_tree_.hpp> #include <ext/pb_ds/detail/rb_tree_map_/rb_tree_.hpp> #include <ext/pb_ds/detail/splay_tree_/splay_tree_.hpp> #include <ext/pb_ds/detail/ov_tree_map_/ov_tree_map_.hpp> #include <ext/pb_ds/detail/cc_hash_table_map_/cc_ht_map_.hpp> #include <ext/pb_ds/detail/gp_hash_table_map_/gp_ht_map_.hpp> #include <ext/pb_ds/detail/pat_trie_/pat_trie_.hpp> #undef PB_DS_DATA_TRUE_INDICATOR #undef PB_DS_V2F #undef PB_DS_V2S #undef PB_DS_EP2VP #define PB_DS_DATA_FALSE_INDICATOR #define PB_DS_V2F(X) (X) #define PB_DS_V2S(X) Mapped_Data() #define PB_DS_EP2VP(X)& ((X)->m_value.first) #include <ext/pb_ds/detail/list_update_map_/lu_map_.hpp> #include <ext/pb_ds/detail/bin_search_tree_/bin_search_tree_.hpp> #include <ext/pb_ds/detail/rb_tree_map_/rb_tree_.hpp> #include <ext/pb_ds/detail/splay_tree_/splay_tree_.hpp> #include <ext/pb_ds/detail/ov_tree_map_/ov_tree_map_.hpp> #include <ext/pb_ds/detail/cc_hash_table_map_/cc_ht_map_.hpp> #include <ext/pb_ds/detail/gp_hash_table_map_/gp_ht_map_.hpp> #include <ext/pb_ds/detail/pat_trie_/pat_trie_.hpp> #undef PB_DS_DATA_FALSE_INDICATOR #undef PB_DS_V2F #undef PB_DS_V2S #undef PB_DS_EP2VP Why are PB_DS_V2F and PB_DS_V2S and PB_DS_EP2VP macros not inline functions provided by type traits? Why are the names so bad? V2F and V2S are presumably value-to-first and value-to-second, but is it necessary to abbreviate them so much? I'm not sure what EP2VP stands for, element pointer to value pointer? Why "element" here and "value" in V2F and V2S? Why "VP" when it returns the same as V2F not the whole value? Why "element pointer" when it could be an iterator too? So many questions. And the & in PB_DS_EP2VP should be addressof (and should not be grouped with the macro name! yuck!)
