https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125228
--- Comment #17 from dragon-archer at outlook dot com --- (In reply to Jonathan Wakely from comment #13) > Please don't change src/c++17/fast_float/fast_float.h either, that's also a > third party library, and your change is completely unnecessary. The > libstdc++ code that includes fast_float.h already does: > > src/c++17/floating_from_chars.cc:# define FASTFLOAT_DEBUG_ASSERT > __glibcxx_assert > > So it's already using __glibcxx_assert and not assert. The third party > library does exactly the right thing and allows its assertions to be > tailored to the project's preferred form. And we do that. So you don't need > to change the code, it already does what you want. This has already been removed from the patch. (In reply to Jonathan Wakely from comment #14) > Thanks for the patch. Libstdc++ patches should be CC'd to the libstdc++ list > as well as gcc-patches. > > https://gcc.gnu.org/contribute.html > > We also need a copyright assignment or DCO sign-off under a real identity, > not an anonymous pseudonym. Got it. Should I send a new patch with the Signed-off-by?
