https://gcc.gnu.org/bugzilla/show_bug.cgi?id=122839

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |jklowden at gcc dot gnu.org,
                   |                            |rdubner at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I'd suggest to copy libobjc/configure.ac --with-target-bdw-gc{,-include,-lib}=
stuff,
just replace bdw-gc with libxml2 or just xml2 (and document it too).
The --with-target-bdw-gc* is documented as:

@item --with-target-bdw-gc=@var{list}
@itemx --with-target-bdw-gc-include=@var{list}
@itemx --with-target-bdw-gc-lib=@var{list}
Specify search directories for the garbage collector header files and
libraries. @var{list} is a comma separated list of key value pairs of the
form @samp{@var{multilibdir}=@var{path}}, where the default multilib key
is named as @samp{.} (dot), or is omitted (e.g.@:
@samp{--with-target-bdw-gc=/opt/bdw-gc,32=/opt-bdw-gc32}).

The options @option{--with-target-bdw-gc-include} and
@option{--with-target-bdw-gc-lib} must always be specified together
for each multilib variant and they take precedence over
@option{--with-target-bdw-gc}.  If @option{--with-target-bdw-gc-include}
is missing values for a multilib, then the value for the default
multilib is used (e.g.@:
@samp{--with-target-bdw-gc-include=/opt/bdw-gc/include}
@samp{--with-target-bdw-gc-lib=/opt/bdw-gc/lib64,32=/opt-bdw-gc/lib32}).
If none of these options are specified, the library is assumed in
default locations.
@end table

I think it wouldn't hurt to also support --without-target-xml2 which would
build libgcobol which would just error on XML PARSE rather than using libxml2.

Also I wonder about
AC_CHECK_LIB(xml2, xmlSAXUserParseMemory,
  [LIBS="-lxml2 $LIBS"
   AC_DEFINE(HAVE_SAX_XML_PARSER, 1,
             [Define to 1 if you have the `xmlSAXUserParseMemory' function.])])
AC_CHECK_LIB(xml2, xmlParseChunk,
  [LIBS="-lxml2 $LIBS"
   AC_DEFINE(HAVE_SAX_XML_PARSER, 1,
             [Define to 1 if you have the `xmlParseChunk' function.])])
in libgcobol/configure.ac, that is twice the same AC_DEFINE each time with
different comment?  Plus nothing really uses those defines...

Reply via email to