https://gcc.gnu.org/bugzilla/show_bug.cgi?id=122852
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Just small nit for next time: (In reply to GCC Commits from comment #7) > Hi, > previously, callback edges of a carrying edge redirected to > __builtin_unreachable were deleted, as I thought they would > mess with the callgraph, given that they were no longer correct. > In some cases, the edges would be deleted when duplicating > a fn summary, producing a segfault. This patch changes this > behavior. It redirects the callback edges to __builtin_unreachable and > adds an exception for such cases in the verifier. Callback edges are > now also required to point to __builtin_unreachable if their carrying > edge is pointing to __builtin_unreachable. > > Bootstrapped and regtested on x86_64-linux, no regressions. > > OK for master? > > Thanks, > Josef The OK for master? Thanks, signature can be certainly left out of the commit message, the Hi! line too and most people leave the Bootstrapped and regtested line out as well. It is desirable (especially the bootstrapped/regtest line per the rules and some sentence where you are asking for ack to which branches too) in the mail thread but less so in the commit message. If you forget to remove it from time to time, of course no big deal.
