------- Additional Comments From jsm at polyomino dot org dot uk  2004-10-27 17:05 
-------
Subject: Re:  Disable special handling of functions with
 --freestanding

On Wed, 27 Oct 2004, alex dot neyman at auriga dot ru wrote:

> The bug 14411 was submitted by me as well, though from a different email 
> address. I updated the patch in it to apply to 4.0. 

You will need to *send the patch to gcc-patches* for reviewers to look at 
it, and iterate as necessary until a version is approved.  See the full 
instructions at <http://gcc.gnu.org/contribute.html> first.  You will need 
to include testcases in the patch, and I suggest naming the setjmp 
attribute something like returns_twice - make it general so it can handle 
vfork as well.  If you don't have the copyright assignment paperwork on 
file yet, start getting it in now.  I don't know whether the present patch 
will require it, but a series of successive patches along those lines 
will.

++ @code{unused}, @code{deprecated}, @code{weak}, @code{malloc}, @code{setjmp},
++ @code{longjmp}, @code{alias}, and @code{nonnull}.  Several other attributes
++ are defined for functions on particular target systems.  Other attributes,
++ including @code{section} are supported for variables declarations

in your patch looks wrong; why add the lines beginning with an extra "+"?

You need two spaces after a "." at the end of a sentence in Texinfo.

K&R-style function definitions are no longer used in GCC.

When adding flags to tree_decl you need to update the comment lower down 
about how many spare bits there are (before another 32-bit word would be 
used).  Note the flags are listed grouped into bytes in the declaration.

`%s' quoting is no longer used in GCC; you should use %qs instead.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18180

Reply via email to