https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118280

--- Comment #27 from Neal Frager <neal.frager at amd dot com> ---
(In reply to Gopi Kumar Bulusu from comment #26)
> Created attachment 61904 [details]
> Revised patch
> 
> With this patch g++ compiler can be used to build programs.
> 
> In particular - this libstdc++ test case (which failed build/execution
> without the patch) builds and runs correctly after the patch
> 
> PASS: 29_atomics/atomic_flag/clear/1.cc  -std=gnu++17 execution test
> 
> This revised patch works with both xl-barrel-shift and no-xl-barrel-shift
> options and handles correct shift calculation for big endian target

Hi Gopi,

Thank you for working on this too!  I just tested and verified the v2 version
of your patch, and I confirm that it works.

I like your patch better because it does not have any dependency on the barrel
shift instructions being enabled.

>From my view, I think we should drop my patch and go with your solution
instead.

In the future, you can add to future versions of your patch.

Reviewed-by: Neal Frager <neal.fra...@amd.com>

Thanks for the great work!

Best regards,
Neal Frager
AMD

Reply via email to