https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120604
--- Comment #16 from Uroš Bizjak <ubizjak at gmail dot com> --- (In reply to David Binderman from comment #15) > Uros writes: > > if ((diff > 0) != ((cf < 0) != (ct < 0) ? cf < 0 : cf < ct)) > > Crikey. IMHO that would fail any code review I took part in. That's because you missed "The check in this additional patch is copied from noce_try_cmove." part in Comment #13. > I think a truth table or some explanatory comment would help. > > I also notice that the same expression is used six times in the same file. > Would it be appropriate to put the expression in a small function, to > show commonality ? Since this construct is also used throughout the generic part of the compiler, IMO it should be provided (together with the truth table) in some utility function, available for all targets.
