https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120308

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Thomas Schwinge from comment #2)
> Created attachment 61442 [details]
> '0001-TYPE_EMPTY_P-vs.-code-offloading-PR120308.patch'
> 
> (In reply to Richard Biener from comment #1)
> > It looks like TYPE_EMPTY_P is only used during RTL expansion for ABI
> > purposes, so computing it during layout_type is premature as shown here.
> 
> Thanks for confirming what I suspected/hoped.
> 
> > I would suggest to simply re-compute it at offload stream-in time.
> 
> I'm testing the patch that I'm attaching here.  Does that look alright?  Do
> I understand correctly that (per (non-)handling of other similar cases) I do
> *not* conditionalize 'compare_values (TYPE_EMPTY_P);' in
> 'gcc/lto/lto-common.cc:compare_tree_sccs_1'?

That looks OK to me, indeed compare_values should be kept.

Reply via email to