https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119629

--- Comment #14 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
ack, patch combining the patchlets in commits 7 and 9 looking good in gcc-14
ppc-elf test results.

I'll point out that this report was not so much about this specific mismatch
between ppc builtins and their corresponding expanders, but about the more
general problem that clearly affects many more ppc builtins.

I'm happy to take your version of the fix for cmpeqb over mine for this
specific problem, silencing the one visible test failure, but I'd like to
suggest keeping the PR open until the more general problem is addressed.

Perhaps the builtins should test the expander condition, if there is a direct
expander, and either disable themselves, or report a mismatch, or something. 
Ignoring the expander condition and leaving it for the compiler to detect it
and ICE is quite undesirable IMHO.

In a perfect world, we'd have a selftest that iterated over the various
available user-controllable configurations and checked that the conditions for
builtin expanders follow from the conditions for the builtins or somesuch.  I'm
not sure that's feasible.

Reply via email to