https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116163

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #19 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Here's the status of test coverage of the dg-lint script pushed above in commit
r15-8992-g8d6de758cca6d16eb930ac1a7008ee54ec5489d9:

(though we probably ought to have examples for these in the test cases below
"contrib")

(In reply to Sam James from comment #2)
> So far, there's a few classes of problem:
> 1) Hyphen typos like 'dg-run', 'dg-compile', ...

Implemented by dg-lint via the KNOWN_DIRECTIVES test.

> 2) Underscore typos like 'dg_final'

Implemented by dg-lint.

> 3) Bad ordering of directives (e.g. 'dg-add-options' vs 'dg-options')

Partially implemented: done for dg-do and dg-require-*, but others could be
added.

> 4) Missing whitespace like '{ dg-do run}'

Implemented by dg-lint.

> 5) Tests in wrong directory (either: 1) wrong filename like .C for g++.dg or
> 2) sometimes even in a directory where it'll do nothing at all & no other
> tests are in there)

Not yet implemented by dg-lint.

> 6) Tests which are clearly meant to be executable but missing 'dg-do run'

Not yet implemented by dg-lint.


(In reply to Sam James from comment #9)
> * Missing dg- prefix (e.g. "// { message }") or "{ require-effective* ... }"
> * s/dg/do/, e.g. "{ do-do compile }"

Not yet implemented.


(In reply to Sam James from comment #10)
> * "dsg-message"
> * "do-message"

Not yet implemented.


(In reply to Sam James from comment #11)
> * dg-options forcing a specific opt level in torture
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82390#c6)

Not yet implemented.

(In reply to Sam James from comment #12)
> * dg-do assemble + scan-assembler-* without -save-temps
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116207#c5)

Not yet implemented.

(In reply to Sam James from comment #13)
> * Use of vect_* target selectors outside of vect/ where it's valid
> (PR113418), may well apply to other selectors too

Not yet implemented.

(In reply to Sam James from comment #14)
> * Tests in lto/ directories not using _N suffix per README will be ignored
> * Tests in lto/ directories using dg-do, dg-options instead of
> dg-lto-{do,options}

Not yet implemented.


(In reply to Sam James from comment #15)
> * "dg -x" (r15-3890-g34bf6aa41ba539)
> * "dg - x" (r15-3890-g34bf6aa41ba539)
> * Bad quoting as in unterminated strings (r15-4792-g2dcb174385fd36)
> * Bad quoting as in regex (r15-4792-g2dcb174385fd36)
> * pinskia pointed out gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[23].c doesn't
> match '|' right (does everything) but there may well be more

Unsure of status.


(In reply to Andrew Pinski from comment #16)
> From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119443#c4
> 
> `{ dg-output-file, "m4.out" }`
> Notice the comma there.

Implemented by dg-lint.


Patches welcome!

Reply via email to