https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119151

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Michael Leuchtenburg from comment #2)
> Created attachment 60672 [details]
> fixed patch

The formatting is wrong.
The GNU Coding Conventions want
      if (iter->entry_count == max_fanout_inner)
        {
          btree_split_inner (t, &iter, &parent, base);
          unsigned parent_slot = btree_node_find_inner_slot (parent, base);
          if (parent->content.children[parent_slot].separator
              < base + size - 1)
            parent->content.children[parent_slot].separator = base + size - 1;
        }
and
      if (iter->content.children[slot].separator < base + size - 1)
        iter->content.children[slot].separator = base + size - 1;
(with tabs instead of 8 spaces in the indentation; the if condition split
because it is then too long for 80 columns.

I'd prefer if Thomas could have a look at the actual algorithm.

Reply via email to