[Bug analyzer/115724] analyzer does not recognise non-returning "error" at -O0 (glibc/GNU extension)

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115724

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by David Malcolm
<dmalc...@gcc.gnu.org>:

https://gcc.gnu.org/g:0f26f4f76961cdc7ebf7f07bec0b370fd1a04972

commit r14-10956-g0f26f4f76961cdc7ebf7f07bec0b370fd1a04972
Author: David Malcolm <dmalc...@redhat.com>
Date:   Thu Jul 4 14:44:51 2024 -0400

    analyzer: handle <error.h> at -O0 [PR115724]

    At -O0, glibc's:

    __extern_always_inline void
    error (int __status, int __errnum, const char *__format, ...)
    {
      if (__builtin_constant_p (__status) && __status != 0)
        __error_noreturn (__status, __errnum, __format, __builtin_va_arg_pack
());
      else
        __error_alias (__status, __errnum, __format, __builtin_va_arg_pack ());
    }

    becomes just:

    __extern_always_inline void
    error (int __status, int __errnum, const char *__format, ...)
    {
      if (0)
        __error_noreturn (__status, __errnum, __format, __builtin_va_arg_pack
());
      else
        __error_alias (__status, __errnum, __format, __builtin_va_arg_pack ());
    }

    and thus calls to "error" are calls to "__error_alias" by the
    time -fanalyzer "sees" them.

    Handle them with more special-casing in kf.cc.

    gcc/analyzer/ChangeLog:
            PR analyzer/115724
            * kf.cc (register_known_functions): Add __error_alias and
            __error_at_line_alias.

    gcc/testsuite/ChangeLog:
            PR analyzer/115724
            * c-c++-common/analyzer/error-pr115724.c: New test.

    Signed-off-by: David Malcolm <dmalc...@redhat.com>
    (cherry picked from commit a6fdb1a2a2906103afd70fa68cf7c45e896b8fbb)