https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114216
--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <ja...@gcc.gnu.org>: https://gcc.gnu.org/g:dea9ac2a00d1e4126d61b65a8302c2bd523f0b99 commit r14-9294-gdea9ac2a00d1e4126d61b65a8302c2bd523f0b99 Author: Jakub Jelinek <ja...@redhat.com> Date: Mon Mar 4 11:40:27 2024 +0100 libgomp: Use void (*) (void *) rather than void (*)() for host_fn type [PR114216] For the type of the target callbacks we use elsehwere void (*) (void *) and IMHO should use that for the reverse offload fallback as well (where the actual callback is emitted using the same code as for host fallback or device kernel entry routines), even when it is also ok to use void (*) () before C23 and we aren't building libgomp with C23 yet. On some arches perhaps void (*) () could result in worse code generation because calls in that case like casts to unprototyped functions need to sometimes pass argument in two different spots etc. so that it deals with both passing it through ... and as a named argument. 2024-03-04 Jakub Jelinek <ja...@redhat.com> PR libgomp/114216 * target.c (gomp_target_rev): Change host_fn type and corresponding cast from void (*)() to void (*) (void *).
