https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111408

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <ja...@gcc.gnu.org>:

https://gcc.gnu.org/g:9866c98e1015d98b8fc346d7cf73a0070cce5f69

commit r14-5841-g9866c98e1015d98b8fc346d7cf73a0070cce5f69
Author: Jakub Jelinek <ja...@redhat.com>
Date:   Sat Nov 25 10:31:55 2023 +0100

    i386: Fix up *jcc_bt*_mask{,_1} [PR111408]

    The following testcase is miscompiled in GCC 14 because the
    *jcc_bt<mode>_mask and *jcc_bt<SWI48:mode>_mask_1 patterns have just
    one argument in (match_operator 0 "bt_comparison_operator" [...])
    but as bt_comparison_operator is eq,ne, we need two.
    The md readers don't warn about it, after all, some checks can
    be done in the predicate rather than specified explicitly, and the
    behavior is that anything is accepted as the second argument.

    I went through all other i386.md match_operator uses and all others
    looked right (extract_operator using 3 operands, all others 2).

    I think we'll want to fix this at different spots in older releases
    because I think the bug was introduced already in 2008, though most
    likely just latent.

    2023-11-25  Jakub Jelinek  <ja...@redhat.com>

            PR target/111408
            * config/i386/i386.md (*jcc_bt<mode>_mask,
            *jcc_bt<SWI48:mode>_mask_1): Add (const_int 0) as expected
            second operand of bt_comparison_operator.

            * gcc.c-torture/execute/pr111408.c: New test.

Reply via email to