https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111360
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Last reconfirmed| |2023-09-11
Status|UNCONFIRMED |NEW
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Eric Gallager from comment #0)
> Running contrib/gcc_update on the gcc111 machine on the compile farm
> includes the following message in its output:
>
> ./contrib/gcc_update[346]: test: argument expected
>
> The line in question has:
>
> if test -n $r; then
>
> Shouldn't the "${r}" be quoted or something?
Yes, either $r is non-empty and the test passes or it's empty and the script is
broken. So you might as well just assume it's non-empty!
It should be quoted. "$r" is fine, there's no need for braces around it.
> Or maybe the issue is actually
> that the command to set it on the previous lines is failing;
Commands can fail. If the script is testing for a non-empty result, presumably
it's acceptable for the command to fail, so the script should just test
correctly.
