https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102989

--- Comment #108 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <ja...@gcc.gnu.org>:

https://gcc.gnu.org/g:3ad9948b3e716885ce66bdf1c8e053880a843a2b

commit r14-3757-g3ad9948b3e716885ce66bdf1c8e053880a843a2b
Author: Jakub Jelinek <ja...@redhat.com>
Date:   Wed Sep 6 17:49:44 2023 +0200

    _BitInt profile fixes [PR102989]

    On Thu, Aug 24, 2023 at 03:14:32PM +0200, Jan Hubicka via Gcc-patches
wrote:
    > this patch extends verifier to check that all probabilities and counts
are
    > initialized if profile is supposed to be present.  This is a bit
complicated
    > by the posibility that we inline !flag_guess_branch_probability function
    > into function with profile defined and in this case we need to stop
    > verification.  For this reason I added flag to cfg structure tracking
this.

    This patch broke a couple of _BitInt tests (in the admittedly still
    uncommitted series - still waiting for review of the C FE bits).

    Here is a minimal patch to make it work again, though I'm not sure
    if in the if_then_else and if_then_if_then_else cases I shouldn't scale
    count of the other bbs as well.  if_then method creates
    if (COND) new_bb1;
    in a middle of some pre-existing bb (with PROB that COND is true),
if_then_else
    if (COND) new_bb1; else new_bb2;
    and if_then_if_then_else
    if (COND1) { if (COND2) new_bb2; else new_bb1; }
    with PROB1 and PROB2 probabilities that COND1 and COND2 are true.
    The lowering happens shortly after IPA.

    2023-09-06  Jakub Jelinek  <ja...@redhat.com>

            PR c/102989
            * gimple-lower-bitint.cc (bitint_large_huge::if_then_else,
            bitint_large_huge::if_then_if_then_else): Use make_single_succ_edge
            rather than make_edge, initialize bb->count.

Reply via email to