https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110360

--- Comment #8 from Mikael Morin <mikael at gcc dot gnu.org> ---

(In reply to anlauf from comment #6)
> (In reply to Mikael Morin from comment #4)
>
> > Looks good.
> > I would suggest to create an overload that avoids duplicating the
> > build_int_cst (integer_type_node, 1) in several places.
> > Shouldn't it be build_int_cst (gfc_charlen_type_node, 1) by the way?
>
> That's true.  I copied that from another snippet.
>
> It is not clear to me what you mean by "overload" here.  Do you want to
> elaborate?
>
Yes, sorry. 
It is a sibling function to the function gfc_string_to_single_character.  It
would have the same name but wouldn't have the len argument (it would create it
with value build_int_cst (gfc_charlen_type_node, 1)).

Reply via email to