https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109564
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Of course, it wouldn't hurt to change the libkeccak as well.
It clearly added
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
to avoid the uninitialized warnings, but in that case they are just asking for
such warnings with their bad style:
const int have_state_size = spec->state_size != (-65536L);
if (have_state_size)
{
state_size = spec->state_size;
...
}
Ugh, why? Just do
state_size = spec->state_size;
if (have_state_size)
{
...
}
Ditto for all the others.
