https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95048

--- Comment #23 from Ulf Lorenz <ulf.lorenz at ptvgroup dot com> ---
I have just one tiny comment on the patches, and that is the tests.

In my original submission, I also modified the tests that verify the path
output (path::wstring() in particular) that AFAIR also had the encoding
problem. In particular, the file
libstdc++-v3/testsuite/27_io/filesystem/path/native/string.cc is lacking a test
with std::path that uses non-Ascii characters.There is test02() which looks
good except that the string "abc" does not catch most conversion problems, and
there is test04() that does not test for path::wstring().

So I think, test04() could just do with a few lines like

#ifdef _GLIBCXX_USE_WCHAR_T
auto strw = p.wstring();
VERIFY( strw == L"\xf0\x9d\x84\x9e");
#endif
  • [Bug libstdc++/95048] [10/11 R... ulf.lorenz at ptvgroup dot com via Gcc-bugs

Reply via email to