https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93483

--- Comment #24 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to anlauf from comment #21)
> 
> Yeah, I was getting just rather close to this one...
> 
Sorry, I didn't want to take it out of your hands.
It seemed that no real solution was emerging.

(In reply to anlauf from comment #23)
> Here's a patch that incorporates comment#17 and comment#20 and adds a
> testcase
> for comment #11.  Regtests fine.
> 
> @Mikael: is it what you suggested?

Yes.
It gives a general direction, but there are a couple of things that I'm not
satisfied with.

First, the ARITH_INVALID_TYPE should be renamed as it has now a broader usage
(ARITH_OP_NOT_LITERAL_VALUE is a bit long, ARITH_OP_NOT_CONSTANT is a bit
misleading, ARITH_OP_NOT_SIMPLIFIED not great either, any other idea?).

Second, I'm wondering whether the check in reduce_binary_aa shouldn't be moved
to reduce binary where it would be more clear.  But then it would be less
consistent with reduce_binary_ac and reduce_binary_ca.

Reply via email to