[Bug fortran/105012] [12/13 Regression] wrf from SPECCPU2017 ICEs during LTO linking since r12-7692-g8db155ddf8cec9

[anlauf at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105012

--- Comment #29 from anlauf at gcc dot gnu.org ---
(In reply to Mikael Morin from comment #28)
> With the following, I get the expected result.
> Indeed, with se->want_pointer set, gfc_conv_expr generates an address
> expression, so it has to be dereferenced to get back the variable.
> 
> diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc
> index 6c8fa16e723..367ecc2eb65 100644
> --- a/gcc/fortran/trans-expr.cc
> +++ b/gcc/fortran/trans-expr.cc
> @@ -9602,7 +9602,7 @@ gfc_conv_expr_reference (gfc_se * se, gfc_expr * expr,
> bool add_clobber)
>           tree var;
>           /* FIXME: This fails if var is passed by reference, see PR
>              41453.  */
> -         var = expr->symtree->n.sym->backend_decl;
> +         var = build_fold_indirect_ref_loc (input_location, se->expr);
>           clobber = build_clobber (TREE_TYPE (var));
>           gfc_add_modify (&se->pre, var, clobber);
>         }

I tried the more hackish

@@ -9529,9 +9540,12 @@ gfc_conv_expr_reference (gfc_se * se, gfc_expr * expr,
bool add_clobber)
        {
          tree clobber;
          tree var;
+         gfc_symbol *sym = expr->symtree->n.sym;
          /* FIXME: This fails if var is passed by reference, see PR
             41453.  */
          var = expr->symtree->n.sym->backend_decl;
+         if (sym->attr.function && sym->result == sym)
+           var = gfc_get_fake_result_decl (sym, 0);
          clobber = build_clobber (TREE_TYPE (var));
          gfc_add_modify (&se->pre, var, clobber);
        }

but if your patch regtests fine then you should proceed.