https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106569
--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> --- (In reply to Jonathan Wakely from comment #5) > (In reply to David Binderman from comment #0) > > Static analyser cppcheck can produce these style messages for gcc trunk > > source code: > > > > $ fgrep useStlAlgorithm cppcheck.20220809.out > > trunk.git/gcc/analyzer/call-string.cc:169:9: style: Consider using > > std::count_if algorithm instead of a raw loop. [useStlAlgorithm] > > I don't think count_if would work here. I haven't looked at the others yet, > but this first one seems like a useless suggestion. The other suggestions for gcc/analyzer/*.cc look correct, or at least, not incorrect, but not all of them would improve clarity. Similarly for the gcc/cp/constexpr.cc suggestions. They would need a lambda expression that captures local variables, and then compare the result of the algorithm to the end iterator of the range. I don't think that would improve the code. It would certainly be more lines of code.
