https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101292

--- Comment #10 from rguenther at suse dot de <rguenther at suse dot de> ---
On Mon, 17 Jan 2022, tschwinge at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101292
> 
> Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |tschwinge at gcc dot gnu.org
> 
> --- Comment #9 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
> (In reply to CVS Commits from comment #7)
> >     The warning control falls into the C++ trap of using a reference
> >     to old hashtable contents for a put operation which can end up
> >     re-allocating that before reading from the old freed referenced to
> >     source.  Fixed by introducing a temporary.
> 
> What the heck...  I'd so much looked into this code and even refactored it in
> context of my earlier commit 
> r12-3498-g6c79057fae6bbb36c4a4fd61c5b7107a16b71b17
> "Don't maintain a warning spec for 'UNKNOWN_LOCATION'/'BUILTINS_LOCATION'
> [PR101574]" -- but I had not noticed that pre-existing problem.  Thanks,
> Richard!

I've only noticed because I (repeatedly...) did the same mistake 
elsewhere.

Reply via email to