https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102828
Martin Sebor <msebor at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hubicka at gcc dot gnu.org
--- Comment #2 from Martin Sebor <msebor at gcc dot gnu.org> ---
Both classes are defined in a header and used in .c/.cc files so they both need
to be public. One either needs to be renamed or put in some namespace.
The predicate defined in ipa-predicate.h is used by IPA (ipa-fnsummary.c and
ipa-predicate.c), the one in gimple-predicate-analysis.h only by
-Wuninitialized for now (tree-ssa-uninit.c) with the goal of being used by
other middle end warnings in the future.
It would be easier for me to rename the one in gimple-predicate-analysis.h but
I'm not coming up with a good name. On the other hand, it seems that the one
in ipa-predicate.h could well be named ipa_predicate. Wrapping all IPA types
and functions in their own namespace (like ipa) seems even more appealing to me
but it would be a lot of churn, probably too much at this point.
Honza, your thoughts/preference?
