https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102408

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Thomas Schwinge <tschwi...@gcc.gnu.org>:

https://gcc.gnu.org/g:e87789f197e47259c94349821d3446f7d959e08f

commit r12-3726-ge87789f197e47259c94349821d3446f7d959e08f
Author: Thomas Schwinge <tho...@codesourcery.com>
Date:   Tue Sep 21 08:54:49 2021 +0200

    Evaluate 'random ()' to '0' in 'pass_omp_oacc_neuter_broadcast'

    Julian Brown,
    <http://mid.mail-archive.com/20210920134603.16459021@squid.athome>:

    | [...] the randomness shouldn't be necessary for the
    | correctness of the patch (i.e. it could just be "base = bounds_lo", or
    | indeed folded into the line after).
    |
    | The "ar.invalid ()" case happens when we fail to allocate a block of
    | memory in LDS space for broadcasting a particular set of variables,
    | and trigger a fall-back path in the broadcasting code that adds extra
    | barriers around the broadcast in question. I imagine I was thinking
    | that adding randomness could mean we can "get lucky" sometimes and
    | avoid needing those barriers in some cases, but in fact I don't think
    | that was implemented, so the randomness is useless. (Or it could just
    | have been leftover debug code... oops).

            gcc/
            PR other/102408
            * omp-oacc-neuter-broadcast.cc (oacc_do_neutering): Evaluate
            'random ()' to '0'.

Reply via email to