[Bug libstdc++/101739] New: Some function parameters in missing uglify

[hewillk at gmail dot com via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101739

            Bug ID: 101739
           Summary: Some function parameters in <ranges> missing uglify
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hewillk at gmail dot com
  Target Milestone: ---

Hey, Patrick, I found that you uglify some function parameters in yesterday’s
r12-2676 to prevent user-defined macros from polluting names.

There are also some function parameters missing uglifying in <ranges>, it will
be more friendly to users if they are underlined:



--- include/std/ranges
+++ include/std/ranges
@@ -1994,8 +1994,8 @@ namespace views::__adaptor
       take_view() requires default_initializable<_Vp> = default;

       constexpr
-      take_view(_Vp base, range_difference_t<_Vp> __count)
-       : _M_count(std::move(__count)), _M_base(std::move(base))
+      take_view(_Vp __base, range_difference_t<_Vp> __count)
+       : _M_count(std::move(__count)), _M_base(std::move(__base))
       { }

       constexpr _Vp
@@ -2180,8 +2180,8 @@ namespace views::__adaptor
        = default;

       constexpr
-      take_while_view(_Vp base, _Pred __pred)
-       : _M_pred(std::move(__pred)), _M_base(std::move(base))
+      take_while_view(_Vp __base, _Pred __pred)
+       : _M_pred(std::move(__pred)), _M_base(std::move(__base))
       { }

       constexpr _Vp
@@ -3782,8 +3782,8 @@ namespace views::__adaptor
       elements_view() requires default_initializable<_Vp> = default;

       constexpr explicit
-      elements_view(_Vp base)
-       : _M_base(std::move(base))
+      elements_view(_Vp __base)
+       : _M_base(std::move(__base))
       { }

       constexpr _Vp
@@ -3903,14 +3903,14 @@ namespace views::__adaptor
          _Iterator() requires default_initializable<iterator_t<_Base>> =
default;

          constexpr explicit
-         _Iterator(iterator_t<_Base> current)
-           : _M_current(std::move(current))
+         _Iterator(iterator_t<_Base> __current)
+           : _M_current(std::move(__current))
          { }

          constexpr
-         _Iterator(_Iterator<!_Const> i)
+         _Iterator(_Iterator<!_Const> __i)
            requires _Const && convertible_to<iterator_t<_Vp>,
iterator_t<_Base>>
-           : _M_current(std::move(i._M_current))
+           : _M_current(std::move(__i._M_current))
          { }

          constexpr const iterator_t<_Base>&



Thank you again for your great contribution to <ranges>. :)