https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99718

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to luoxhu from comment #1)
> Confirmed.  Another case forgot to test m32 again :(
> 
> David mentioned no need variable vec_insert support for m32 build, so I
> think we should avoid generating IFN VEC_SET in
> gimple-isel.c:gimple_expand_vec_set_expr, but it seems not possible to check
> "TARGET_P8_VECTOR && TARGET_DIRECT_MOVE_64BIT" in the common file or through
> can_vec_set_var_idx_p. Any suggestions?
> 
> https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564403.html

If the non-constant vec_set can't be supported when
!(TARGET_P8_VECTOR && TARGET_DIRECT_MOVE_64BIT)
then
(define_expand "vec_set<mode>"
  [(match_operand:VEC_E 0 "vlogical_operand")
   (match_operand:<VEC_base> 1 "register_operand")
   (match_operand 2 "reg_or_cint_operand")]
  "VECTOR_MEM_ALTIVEC_OR_VSX_P (<MODE>mode)"
{
  rs6000_expand_vector_set (operands[0], operands[1], operands[2]);
  DONE;
})
should be changed, perhaps add a new predicate that for
TARGET_P8_VECTOR && TARGET_DIRECT_MOVE_64BIT
is equivalent to reg_or_cint_operand and otherwise to const_int_operand?
(define_predicate "vec_set_index_operand"
  (if_then_else (match_test "TARGET_P8_VECTOR && TARGET_DIRECT_MOVE_64BIT")
    (match_operand 0 "reg_or_cint_operand")
    (match_operand 0 "const_int_operand")))

Reply via email to