https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95582

--- Comment #15 from Richard Biener <rguenth at gcc dot gnu.org> ---
The patch causes g++.dg/vect/simd-bool-comparison-1.cc to FAIL because
it will result in signed BOOLEAN_TYPEs with precision 1 rejected.  Those we
use for build_nonstandard_boolean_type via

#0  0x0000000001b93458 in build_truth_vector_type_for_mode (nunits=...,
mask_mode=E_DImode) at /home/rguenther/src/gcc3/gcc/tree.c:10931
#1  0x0000000001b935a2 in build_truth_vector_type_for (vectype=<vector_type
0x7ffff69c0bd0>) at /home/rguenther/src/gcc3/gcc/tree.c:10949
#2  0x0000000001b96175 in truth_type_for (type=<vector_type 0x7ffff69c0bd0>) at
/home/rguenther/src/gcc3/gcc/tree.c:11764
#3  0x0000000001ae92b6 in get_mask_type_for_scalar_type (vinfo=0x3beccd0,
scalar_type=<boolean_type 0x7ffff682bb28 bool>, group_size=0)
    at /home/rguenther/src/gcc3/gcc/tree-vect-stmts.c:11137
#4  0x00000000028cfaee in vect_recog_mask_conversion_pattern (vinfo=0x3beccd0,
stmt_vinfo=0x3da6ae0, type_out=0x7fffffffc320)
    at /home/rguenther/src/gcc3/gcc/tree-vect-patterns.c:4354

which then causes the VECT_SCALAR_BOOLEAN_TYPE_P result to differ even for C++
at

#1  0x0000000001abfa11 in VECT_SCALAR_BOOLEAN_TYPE_P (TYPE=<boolean_type
0x7ffff69c01f8>) at /home/rguenther/src/gcc3/gcc/tree-vectorizer.h:1425
#2  0x0000000001ae41c1 in vect_is_simple_cond (cond=<ssa_name 0x7ffff69cd828
22>, vinfo=0x3beccd0, stmt_info=0x3da7410, slp_node=0x0, 
    comp_vectype=0x7fffffffbbe0, dts=0x7fffffffbbb0, vectype=<vector_type
0x7ffff68f7150>) at /home/rguenther/src/gcc3/gcc/tree-vect-stmts.c:9711
#3  0x0000000001ae49bf in vectorizable_condition (vinfo=0x3beccd0,
stmt_info=0x3da7410, gsi=0x0, vec_stmt=0x0, slp_node=0x0,
cost_vec=0x7fffffffc1b8)
    at /home/rguenther/src/gcc3/gcc/tree-vect-stmts.c:9876

now the Ada issue was about non-1 precision BOOLEAN_TYPE, so we could narrow
down the fix.  But then the question is why we allow signed 1-bit bools
but not signed 1-bit integers...

So I'm first re-testing

 #define VECT_SCALAR_BOOLEAN_TYPE_P(TYPE) \
-  (TREE_CODE (TYPE) == BOOLEAN_TYPE            \
-   || ((TREE_CODE (TYPE) == INTEGER_TYPE       \
-       || TREE_CODE (TYPE) == ENUMERAL_TYPE)   \
-       && TYPE_PRECISION (TYPE) == 1           \
-       && TYPE_UNSIGNED (TYPE)))
+  (INTEGRAL_TYPE_P (TYPE)               \
+   && TYPE_PRECISION (TYPE) == 1)

Reply via email to