https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96203

--- Comment #15 from rguenther at suse dot de <rguenther at suse dot de> ---
On Fri, 17 Jul 2020, hjl.tools at gmail dot com wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96203
> 
> --- Comment #14 from H.J. Lu <hjl.tools at gmail dot com> ---
> (In reply to Richard Biener from comment #13)
> > (In reply to H.J. Lu from comment #12)
> > > Please this patch.
> > 
> > /* Merge and update the -fcf-protection option.  */
> > 
> > but here you take the setting from the last file rather than merging it,
> > I'd have expected a |= operation and also handling of CF_FULL for the
> > string update.
> 
> The code has
> 
>            /* Merge and update the -fcf-protection option.  */
> +           (*decoded_options)[j].value &= (foption->value
> +                       & CF_FULL);
> 
> It must be "&=" not "|=" since CET features are enabled only if they are
> enabled in ALL LTO inputs.

OK, so it mimics what the dynamic loader would do (and also the
link editor?).

Reply via email to