https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95177
--- Comment #4 from Steve Kargl <sgk at troutmask dot apl.washington.edu> --- On Tue, May 19, 2020 at 04:38:32AM +0000, roland.illig at gmx dot de wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95177 > > --- Comment #2 from Roland Illig <roland.illig at gmx dot de> --- > >--- Comment #1 from kargl at gcc dot gnu.org --- > >Why cast to unsigned char? The prototypes for tolower(), toupper(), > >isdigit(), etc show that the type of the argument is int. > > See https://stackoverflow.com/a/60696378 for a detailed explanation. > Ah, yeah, so? There are no subscripts in the code you are changing. Why does -Werror=char-subscripts trigger if there are no subscripts? Is the error flag misnamed? If you're going to fix unbroken code, why not cast the argument to the declared type of the ctype functions?
